Conversation
…ble Chrome Chrome for Testing builds since v151 require macOS 13+. On macOS 12, the download succeeds but the binary crashes immediately on launch (SIGABRT). Detect the macOS version at runtime in fetch_download_url() and fail with a clear message pointing to the manual install option, rather than wasting bandwidth on a broken binary. Test: macos_version() returns Some on macOS, None on other platforms (which skips the version check).
Contributor
|
@holny is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-browser installon macOS 12 downloads the latest Chrome for Testing (v151+), which requires macOS 13+. The binary crashes immediately on launch with SIGABRT, wasting bandwidth and producing a confusing failure.fetch_download_url(). When the macOS major version is below 13, fail immediately with a clear error message pointing to the manual install option. On non-macOS platforms the check is a no-op.macos_version_returns_some_on_macostest); fmt/clippy clean.AI-assisted content (per CONTRIBUTING.md): drafted by my local agent, reviewed and posted by me.